Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make options arg optional. #9

Merged
merged 1 commit into from
Mar 21, 2020
Merged

Conversation

OmgImAlexis
Copy link
Contributor

Since both functions use options = {} there's no need to force the options argument.

This now allows the following.

import * as fdir from 'fdir';

fdir.async('/').then(files => {
    console.log(files);
});

Where as before you'd need to pass an empty second param.

import * as fdir from 'fdir';

fdir.async('/', {}).then(files => {
    console.log(files);
});

@thecodrr
Copy link
Owner

Hey, thanks for this. Must have slipped my observation!

@thecodrr thecodrr merged commit 31678ac into thecodrr:master Mar 21, 2020
@OmgImAlexis OmgImAlexis deleted the patch-1 branch March 21, 2020 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants