-
-
Notifications
You must be signed in to change notification settings - Fork 33
WIP: Firms update staging #286
Conversation
… start with the same sequence of characters
We have to restore databases easily and this just automates it
docker-compose.yml
Outdated
@@ -48,3 +48,6 @@ services: | |||
image: mariadb:10.2.15 | |||
env_file: .env | |||
restart: unless-stopped | |||
command: ["mysqld", "--default-authentication-plugin=mysql_native_password"] | |||
ports: | |||
- 3306:3306 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't want to expose our database! The credentials are open and database should be accessible only to the isolated network of containers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, didn't mean to commit that, was just exposing it locally for debugging. 😛
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay!
Added the version command.
I merged the feature branches into here so we don't have to deal with the mess of branches later. |
Awesome! |
…tor_bot into thecsw-firm_tax_update
Stale. It is not used. Payroll will do the payouts
I am not entirely sure why we did that
Got rid of the boost attribute.
Changed zip release to the name of the package.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, please do the honors! Don't forget to add your name to our list of contributors!
EDIT: This branch is now being treated as a staging branch for the firms update
(Work in progress)
Closes #272
Closes #295
I'm setting up simple unit tests here to more easily finish the work on #271 without having to manually try each command on Reddit. This PR won't have 100% test coverage, but should save time by covering the core of the bot's behavior.
My plan is to mock out the
praw
comment API andsqlachemy
session API enough to be able to run commands against theCommentWorker
.