Skip to content
This repository has been archived by the owner on Oct 14, 2019. It is now read-only.

WIP: Firms update staging #286

Merged
merged 96 commits into from
Jan 17, 2019
Merged

WIP: Firms update staging #286

merged 96 commits into from
Jan 17, 2019

Conversation

mappum
Copy link
Contributor

@mappum mappum commented Dec 27, 2018

EDIT: This branch is now being treated as a staging branch for the firms update


(Work in progress)
Closes #272
Closes #295

I'm setting up simple unit tests here to more easily finish the work on #271 without having to manually try each command on Reddit. This PR won't have 100% test coverage, but should save time by covering the core of the bot's behavior.

My plan is to mock out the praw comment API and sqlachemy session API enough to be able to run commands against the CommentWorker.

@ghost ghost assigned mappum Dec 27, 2018
@ghost ghost added the in progress label Dec 27, 2018
@@ -48,3 +48,6 @@ services:
image: mariadb:10.2.15
env_file: .env
restart: unless-stopped
command: ["mysqld", "--default-authentication-plugin=mysql_native_password"]
ports:
- 3306:3306
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't want to expose our database! The credentials are open and database should be accessible only to the isolated network of containers

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, didn't mean to commit that, was just exposing it locally for debugging. 😛

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay!

@thecsw thecsw self-requested a review December 29, 2018 09:16
@mappum
Copy link
Contributor Author

mappum commented Jan 15, 2019

I merged the feature branches into here so we don't have to deal with the mess of branches later.

@thecsw
Copy link
Owner

thecsw commented Jan 15, 2019

Awesome!

@mappum mappum mentioned this pull request Jan 17, 2019
Stale. It is not used. Payroll will do the payouts
I am not entirely sure why we did that
Got rid of the boost attribute.
Changed zip release to the name of the package.
Copy link
Owner

@thecsw thecsw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, please do the honors! Don't forget to add your name to our list of contributors!

@mappum mappum merged commit 453f7b6 into master Jan 17, 2019
@ghost ghost removed the in progress label Jan 17, 2019
@thecsw thecsw deleted the tests branch February 3, 2019 01:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants