Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #38053 - Remove syspurpose addons from Foreman #10394

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

chris1984
Copy link
Member

@chris1984
Copy link
Member Author

@jeremylenz 👀

@jeremylenz
Copy link
Contributor

Test failures look like they might be related.

jeremylenz
jeremylenz previously approved these changes Dec 3, 2024
Copy link
Contributor

@jeremylenz jeremylenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, let's just get the tests green. APGHA 👍

* In Katello/katello#11196 we removed syspurpose addons from Katello. I didn't realize we had them in Foreman too.
@chris1984
Copy link
Member Author

@jeremylenz checking from my phone but they all passed it looks like 😄

Copy link
Contributor

@jeremylenz jeremylenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@jeremylenz jeremylenz merged commit 76dcbbe into theforeman:develop Dec 4, 2024
51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants