Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use shared GitHub Action for Ruby tests #133

Merged
merged 4 commits into from
Jan 25, 2024
Merged

Use shared GitHub Action for Ruby tests #133

merged 4 commits into from
Jan 25, 2024

Conversation

evgeni
Copy link
Member

@evgeni evgeni commented Jan 25, 2024

No description provided.

if: github.event_name != 'push'
run: |
bundle exec rake test:foreman_leapp -v --trace
bundle exec rake test TEST="test/unit/foreman/access_permissions_test.rb" -v --trace
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we want to seed templates that include `provider_type: Ansible`
Comment on lines +3 to +4
require 'foreman_ansible'
require 'foreman_remote_execution'
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this fixes #120

(technically, I guess, foreman_ansible would be enough, but I felt like being explicit here)

Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the require statement is correct. I'm not sure how else it could be solved.

.github/workflows/ruby.yml Outdated Show resolved Hide resolved
Co-authored-by: Ewoud Kohl van Wijngaarden <[email protected]>
@stejskalleos stejskalleos merged commit 4c857c3 into master Jan 25, 2024
7 of 8 checks passed
@stejskalleos
Copy link
Contributor

Thanks @evgeni @ekohl

@evgeni evgeni deleted the gha branch January 25, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants