Fix environment param in smart proxies controller #413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtancoigne
force-pushed
the
fix-environment-param
branch
from
5af0a34 to
f8a53c7
Compare
|
@ekohl Could you unlock the CI run? plz |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
We noticed an issue in the way environments parameter is used in the proxies controller:
routes
/api/environments/:environment/handles environment name as:environmentparam, while/api/environments/:environment/smart_proxies/:smart_proxy_id/import_puppetclassessearches for a numerical identifier.This leads to all the environments being imported when a name is specified.
To stay consistent, the fix uses the same method as the one used on
/api/environments/:environment/to find the environment.