Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The "Insights" tab is displayed for all operating systems #910

Closed
Thorben-D opened this issue Oct 2, 2024 · 0 comments · Fixed by #911
Closed

The "Insights" tab is displayed for all operating systems #910

Thorben-D opened this issue Oct 2, 2024 · 0 comments · Fixed by #911

Comments

@Thorben-D
Copy link
Contributor

After installing the RH Cloud plugin, the Insights tab is displayed for each operating system on the host details page, although this is a RHEL feature.

image

Steps to Reproduce:

  1. install the RH Cloud plugin
  2. check the host details page under "Hosts-->All Hosts-->hostname"

Actual results:
The "Insights" tab is displayed for all operating systems

Expected results:
The "Insights" tab is displayed only for RHEL operating systems

The same applies to the total risk card on the overview tab.
Thorben-D added a commit to Thorben-D/foreman_rh_cloud that referenced this issue Oct 2, 2024
@Thorben-D
Fixes theforeman#910 - Insights tab displayed for non-RHEL hosts
0e67b29 
- Add helper-function isNotRhelHost
- Hide insights tab based on host-OS
- Hide TotalRist card based on host-OS
Thorben-D added a commit to Thorben-D/foreman_rh_cloud that referenced this issue Oct 2, 2024
@Thorben-D
Fixes theforeman#910 - Insights tab displayed for non-RHEL hosts
7bf0790 
- Add helper-function isNotRhelHost
- Hide insights tab based on host-OS
- Hide TotalRisk card based on host-OS
@Thorben-D Thorben-D mentioned this issue Oct 2, 2024
Merged
chris1984 pushed a commit that referenced this issue Oct 22, 2024
@Thorben-D @chris1984
Fixes #910 - Insights tab displayed for non-RHEL hosts
4b34441 
- Add helper-function isNotRhelHost
- Hide insights tab based on host-OS
- Hide TotalRisk card based on host-OS
@Thorben-D Thorben-D mentioned this issue Oct 30, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes #910 - Insights tab displayed for non-RHEL hosts Thorben-D/foreman_rh_cloud
1 participant
@Thorben-D