-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use shared github workflow to run tests #866
Conversation
cold cache: 13m 24s (https://github.com/theforeman/foreman_rh_cloud/actions/runs/7567480704/job/20606728804) so, while slower, certainly not bad |
Should this also drop the "build container" workflows, since they're no longer needed? |
This fails in a migration, probably because the plugin can't be installed after Foreman has already been installed. I suppose that's another difference in migrations. Perhaps our reusable action should test both approaches. |
Correct.
|
b713c1d
to
71cc8dc
Compare
b0ac1de
to
a1f8c8f
Compare
@evgeni , can you define the version of Foreman you want to use for the tests? I see the action uses the develop branch by default. It won't be good enough for stable branches. |
Of course, which ones would you like? 3.9 and develop? |
I've implemented 3.9 an develop now, what do you think? :) |
@ShimShtein could you have a look? |
Merged, thanks @evgeni ! Do you expect we will need to cherry-pick this one to older branches of the plugin? |
Nah, as long as it's in the one for 3.10, we're good |
Which version of Katello are we using? I will probably need to freeze Katello and REX versions. Is there an option to do that, or do I need to freeze them in the gemspec? |
Whichever the gemspec allows is used, yeah. |
No description provided.