Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use shared github workflow to run tests #866

Merged
merged 4 commits into from
Mar 10, 2024
Merged

Conversation

evgeni
Copy link
Member

@evgeni evgeni commented Jan 18, 2024

No description provided.

@ekohl
Copy link
Member

ekohl commented Jan 18, 2024

Should this also drop the "build container" workflows, since they're no longer needed?

@ekohl
Copy link
Member

ekohl commented Jan 18, 2024

This fails in a migration, probably because the plugin can't be installed after Foreman has already been installed. I suppose that's another difference in migrations. Perhaps our reusable action should test both approaches.

@evgeni
Copy link
Member Author

evgeni commented Jan 22, 2024

This fails in a migration, probably because the plugin can't be installed after Foreman has already been installed. I suppose that's another difference in migrations. Perhaps our reusable action should test both approaches.

Correct.

@evgeni evgeni force-pushed the shared-action branch 2 times, most recently from b713c1d to 71cc8dc Compare January 22, 2024 08:47
@evgeni
Copy link
Member Author

evgeni commented Jan 22, 2024

I've split out some of the changes here into #867 and #868 as they are only indirectly related to the whole GHA change

@evgeni evgeni mentioned this pull request Jan 22, 2024
@evgeni evgeni force-pushed the shared-action branch 2 times, most recently from b0ac1de to a1f8c8f Compare January 22, 2024 14:53
foreman_rh_cloud.gemspec Outdated Show resolved Hide resolved
@ShimShtein
Copy link
Member

@evgeni , can you define the version of Foreman you want to use for the tests? I see the action uses the develop branch by default. It won't be good enough for stable branches.

@evgeni
Copy link
Member Author

evgeni commented Jan 23, 2024

Of course, which ones would you like? 3.9 and develop?

@evgeni
Copy link
Member Author

evgeni commented Jan 23, 2024

Of course, which ones would you like? 3.9 and develop?

I've implemented 3.9 an develop now, what do you think? :)

@ekohl
Copy link
Member

ekohl commented Mar 7, 2024

@ShimShtein could you have a look?

@ShimShtein ShimShtein merged commit d8fb53e into foreman_3_9 Mar 10, 2024
12 checks passed
@ShimShtein ShimShtein deleted the shared-action branch March 10, 2024 12:01
@ShimShtein
Copy link
Member

Merged, thanks @evgeni !

Do you expect we will need to cherry-pick this one to older branches of the plugin?

@evgeni
Copy link
Member Author

evgeni commented Mar 10, 2024

Nah, as long as it's in the one for 3.10, we're good

@ShimShtein
Copy link
Member

Which version of Katello are we using? I will probably need to freeze Katello and REX versions. Is there an option to do that, or do I need to freeze them in the gemspec?

@evgeni
Copy link
Member Author

evgeni commented Mar 10, 2024

Whichever the gemspec allows is used, yeah.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

3 participants