Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deploy downloads to website01 #511

Merged
merged 1 commit into from
Dec 9, 2024
Merged

deploy downloads to website01 #511

merged 1 commit into from
Dec 9, 2024
+2 −2

Conversation

evgeni
Copy link
Member

@evgeni evgeni commented Nov 28, 2024

No description provided.

@evgeni evgeni mentioned this pull request Nov 28, 2024
Merged
ekohl
ekohl reviewed Dec 4, 2024
View reviewed changes
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is the hostname website01? I'd have thought web02 would be more logical. My mind thought it was short for webserver

@evgeni
Copy link
Member Author

evgeni commented Dec 5, 2024

Why is the hostname website01? I'd have thought web02 would be more logical. My mind thought it was short for webserver

Idk what I thought when I created it, but it's there now.

@evgeni
Copy link
Member Author

evgeni commented Dec 5, 2024 •
edited
Loading

Oooh, probably because I didn't want it to match web\d+ that's used to apply the big web class/profile

And because it's not the webserver anymore. It's one webserver (hosting the website), and we have others (repo-*)

@evgeni evgeni mentioned this pull request Dec 9, 2024
Merged
@ekohl
Copy link
Member

ekohl commented Dec 9, 2024

Oooh, probably because I didn't want it to match web\d+ that's used to apply the big web class/profile

That's fair. It's indeed not an exact drop in.

@evgeni evgeni marked this pull request as ready for review December 9, 2024 13:59
@evgeni evgeni merged commit 92d03ea into master Dec 9, 2024
2 checks passed
@evgeni evgeni deleted the move-downloads branch December 9, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehelms ehelms ehelms approved these changes

@ekohl ekohl ekohl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@evgeni @ekohl @ehelms