Correct documentation on Candlepin certs #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekohl
commented
Dec 15, 2017
README.md
Outdated
| @@ -38,7 +38,8 @@ for communication between services inside the Katello deployment. | |||
| | ${hostname}-parent-cert | a client certificate to read content from Pulp parent (distributed to the child over qpid) | default | | |||
| | ${hostname}-qpid-broker | a client certificate for qpid broker | default | | |||
| | ${hostname}-qpid-client-cert | a client certificate for Pulp to connect to qpid | default | | |||
| | java-client | a client certificate for Candlpin to connect to qpid | default | | |||
| | ${hostname}-tomcat | a server certificate for Candlepin http | default | | |||
There was a problem hiding this comment.
This may not be right. It looks like this is used as intermediates to import into the NSS db.
There was a problem hiding this comment.
Without doing a hard check, I'd think this certificate was for building up the trustore and keystore for use by Tomcat server. IIRC nssdb is only used for qpidd.
ekohl
commented
Jan 10, 2018
README.md
Outdated
| @@ -38,7 +38,8 @@ for communication between services inside the Katello deployment. | |||
| | ${hostname}-parent-cert | a client certificate to read content from Pulp parent (distributed to the child over qpid) | default | | |||
| | ${hostname}-qpid-broker | a client certificate for qpid broker | default | | |||
| | ${hostname}-qpid-client-cert | a client certificate for Pulp to connect to qpid | default | | |||
| | java-client | a client certificate for Candlpin to connect to qpid | default | | |||
| | ${hostname}-tomcat | a server certificate for Candlepin http | default | | |||
| | java-client | a client certificate for Candlepin to connect to qpid | default | | |||
There was a problem hiding this comment.
@ehelms I do think this line is correct. If so, I'll revert the other one.
ekohl
force-pushed
the
fix-candlepin-certs
branch
from
ecf9fd1 to
f61f335
Compare
|
Since now it was just a trivial typo fix I pushed it to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.