fixes #24210 - certs group must be overridable #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For Katello, we override the certs ownership so Foreman can read it. This is required for WebVNC: the foreman user launches websockify using the certificate.
ekohl
approved these changes
Jul 9, 2018
|
Yup, easy to miss :-\ It doesn't help websockify.py has no logs to find out the problem. Thanks for quick review |
|
Don't we log that to production.log? |
|
I don't think so, but even if it did, websockify itself doesn't seem to have any output when it can't read the certs, it still starts. Maybe I can fix that, too. Will have a look |
chris1984
approved these changes
Jul 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Katello, we override the certs ownership so Foreman can read it.
This is required for WebVNC: the foreman user launches websockify
using the certificate.
Partially reverts #168