Certs module cleanup #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
iNecas
commented
Jan 14, 2014
iNecas
commented
- Use custom providers for certs generation instead of exec katello-ssl-tool
- Move the certs bits from other modules: every service has dedicated pp file with all things specific the the service
- Httpd doesn't use candlepin-ca as ssl cert, instead ca generates new ssl cert to be used. Thanks to chaining, the verification from clients should still work without issues (the approach already tested previously with nodes)
- Foreman uses certs originate in candlepin-ca instead of puppetca certs (as it already did with nodes)
| @@ -33,7 +34,7 @@ def self.details(cert_name) | |||
| def self.pubkey(name) | |||
| # TODO: just temporarily until we have this changes in katello installer as well | |||
| if name == 'candlepin-ca' | |||
| '/usr/share/katello/candlepin-cert.crt' | |||
| '/usr/share/katello/candlepin-ca.crt' | |||
There was a problem hiding this comment.
Katello is no longer installed in /usr/share/katello due to being a gem. I think we need to figure out a new home for this.
There was a problem hiding this comment.
Well, I think we don't need to have it in /usr/share/katello and use standard /etc/pki/tls/certs, we need to update https://github.com/Katello/katello-misc/blob/master/certs-tools/certs/katello_ssl_tool.py#L569,
I would like to address that after the basic is merged.
Causes various troubles across the tools.
|
ACK, merging to open branch against master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.