Fixes #7210 - make sure the Package['pulp-server'] is defined #31
Conversation
Otherwise, capsule-certs-generate is broken
| @@ -26,6 +26,8 @@ | |||
| class { 'certs::apache': hostname => $capsule_fqdn } | |||
| class { 'certs::qpid': hostname => $capsule_fqdn } | |||
| class { 'certs::pulp_child': hostname => $capsule_fqdn } | |||
|
|
|||
| include ::pulp::install | |||
There was a problem hiding this comment.
Why do an include instead of a require => Package['pulp-server'] ?
There was a problem hiding this comment.
We need to include for the Package['pulp-server'] to be even defined. The require is already there https://github.com/iNecas/puppet-certs/blob/issue/7210/manifests/pulp_parent.pp#L60
There was a problem hiding this comment.
That seems disconnected to me - should the pulp_parent class no include the install then?
There was a problem hiding this comment.
When doing that, you would get errors in katello-installer, because katello-installer already defines those somewhere else: this came out as the best place to put it to make everyone happy and don't infer with katello-installer
There was a problem hiding this comment.
I'll take it, but this module scares me more and more everyday :)
There was a problem hiding this comment.
Welcome to the x509 hell :)
|
Tested and works for me! |
|
The travis is failing because of http://projects.theforeman.org/issues/7147, temp fix here #29 |
Fixes #7210 - make sure the Package['pulp-server'] is defined
Otherwise, capsule-certs-generate is broken