incorporate suggestions

theforeman · Jul 29, 2020 · 2c87103 · 2c87103
1 parent 9105581
commit 2c87103
Showing 1 changed file with 2 additions and 4 deletions.
diff --git a/manifests/plugin/default_hostgroup.pp b/manifests/plugin/default_hostgroup.pp
@@ -3,18 +3,16 @@
 # @param hostgroups An array of hashes of hostgroup names and facts to add to the configuration
 #
 class foreman::plugin::default_hostgroup (
-  Array[Hash] $hostgroups = [],
+  Array[Hash[String, Hash]] $hostgroups = [],
 ){
   if empty($hostgroups) {
     $config = undef
-    $config_file = undef
   } else {
     $config = template('foreman/default_hostgroup.yaml.erb')
-    $config_file = "${foreman::plugin_config_dir}/default_hostgroup.yaml"
   }
 
   foreman::plugin {'default_hostgroup':
     config      => $config,
-    config_file => $config_file,
+    config_file => "${foreman::plugin_config_dir}/default_hostgroup.yaml"
   }
 }