Introduce foreman::settings_fragment #1016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It's possible to create a create_resource for manage that with hiera ? And maybe a validation with a custom type (or this is too much)? I can look that in different pull request |
|
I'd prefer that in a separate PR. I can't find the bug right now, but note we have some issues in our installer parsing types that span multiple lines. That is likely to show up there. |
ekohl
force-pushed
the
settings_fragment-api
branch
from
f7afe81 to
785677f
Compare
Merged
bastelfreak
reviewed
Feb 3, 2022
| order: '42', | ||
| } | ||
| end | ||
|
|
There was a problem hiding this comment.
should we add a:
it { is_expected.to compile.with_all_deps }
?
This provides a stable API to provide fragments to settings.yaml. This means we don't need to create parameters for every single setting.
ekohl
force-pushed
the
settings_fragment-api
branch
from
785677f to
d4ee7d4
Compare
bastelfreak
approved these changes
Feb 3, 2022
evgeni
approved these changes
Feb 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This provides a stable API to provide fragments to settings.yaml. This means we don't need to create parameters for every single setting.