derive base_url from foreman-proxy/settings.yml by default #1053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhoblitt
force-pushed
the
feature/automagic_base_url
branch
from
cce7e29 to
3b9c566
Compare
jhoblitt
force-pushed
the
feature/automagic_base_url
branch
from
3b9c566 to
21a8176
Compare
|
rebased on current master |
ehelms
approved these changes
May 23, 2022
jhoblitt
force-pushed
the
feature/automagic_base_url
branch
from
21a8176 to
fd6a79e
Compare
|
rebased on current master. |
Setting the base_url param on all foreman_* resource declarations isn't very DRY (resource defaults are another option). Deriving this value from /etc/foreman-proxy/settings.yml is consistent with looking up tls/oauth data in /etc/foreman/settings.yaml.
jhoblitt
force-pushed
the
feature/automagic_base_url
branch
from
fd6a79e to
83c8f59
Compare
|
rebased on current master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting the base_url param on all foreman_* resource declarations isn't
very DRY (resource defaults are another option). Deriving this value
from /etc/foreman-proxy/settings.yml is consistent with looking up
tls/oauth data in /etc/foreman/settings.yaml.