Fixes #21023 - Update start-timeout to 90 #603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
My understanding the new plan was to lower the 600 second waiting of passenger to 90 so it matches the systemd default. @ehelms? |
|
Yep.
…On Oct 25, 2017 8:02 AM, "Ewoud Kohl van Wijngaarden" < ***@***.***> wrote:
My understanding the new plan was to lower the 600 second waiting of
passenger to 90 so it matches the systemd default. @ehelms
<https://github.com/ehelms>?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#603 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAR584BAgEeQn38PuZccshhffavZ_9Xeks5svyNHgaJpZM4QFAtL>
.
|
chris1984
changed the title
|
@ekohl can I get another review of this please? test failure looks unrelated An error occurred while loading ./spec/acceptance/foreman_cli_spec.rb. |
|
@chris1984 see https://www.traviscistatus.com/incidents/v4jnp6nkgzqx for the docker timeout. |
ekohl
approved these changes
Oct 26, 2017
|
@ekohl tests are passing now, can I get a merge please? |
|
merged, thanks @chris1984! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.