Adding wreckingball Plugin #647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
ekohl
approved these changes
Jun 19, 2018
ekohl
requested changes
Jun 19, 2018
| @@ -0,0 +1,5 @@ | |||
| # Installs foreman_wreckingball plugin | |||
There was a problem hiding this comment.
Looks like the file should be named wreckingball.pp instead of foreman_wreckingball.pp
theforeman-bot
added
Waiting on contributor
Needs re-review
Needs testing
and removed
Waiting on contributor
labels
new file: manifests/plugin/wreckingball.pp new file: spec/classes/plugin/wreckingball_spec.rb
|
I add a trivial Test, and renamed the File. |
ekohl
approved these changes
Jun 22, 2018
|
Thanks! |
cegeka-jenkins
pushed a commit
to cegeka/puppet-foreman
that referenced
this pull request
Jul 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding wreckingball plugin. RPM available here