Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use deb gpg key from our server, not the gpg network #924

Merged
merged 1 commit into from
Mar 23, 2021

Conversation

evgeni
Copy link
Member

@evgeni evgeni commented Mar 23, 2021

also ensure the key is refreshed if expired

@evgeni
Copy link
Member Author

evgeni commented Mar 23, 2021

I do wonder if we should just use apt::key directly once, instead of twice in the definition of the repos.

manifests/repos/apt.pp Outdated Show resolved Hide resolved
manifests/repos/apt.pp Outdated Show resolved Hide resolved
@ekohl
Copy link
Member

ekohl commented Mar 23, 2021

I do wonder if we should just use apt::key directly once, instead of twice in the definition of the repos.

That probably makes sense.

@evgeni evgeni force-pushed the refresh-key branch 3 times, most recently from 0471b15 to 7a4c2b1 Compare March 23, 2021 15:40
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I merged the systemd pin PR so if you update, please rebase.

manifests/repos/apt.pp Outdated Show resolved Hide resolved
manifests/repos/apt.pp Outdated Show resolved Hide resolved
manifests/repos/apt.pp Show resolved Hide resolved
@ehelms
Copy link
Member

ehelms commented Mar 23, 2021

Pin camptocamp has been merged, so now you can drop it :)

also ensure the key is refreshed if expired
@ekohl ekohl changed the title use key from our server, not the gpg network use deb gpg key from our server, not the gpg network Mar 23, 2021
@ekohl ekohl merged commit da94883 into theforeman:master Mar 23, 2021
@ekohl
Copy link
Member

ekohl commented Mar 23, 2021

Technically this changes a parameter but since it's a private API I don't consider it breaking, hence an enhancement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants