Match Foreman user to what packaging creates #971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This matches what the RPM and Debian packages already do so it should have no effect in reality, but it does align the two.
In dcb8a70 the shell was changed from /sbin/nologin to /bin/false since on Debian it is /usr/sbin/nologin. Technically we can now always use /usr/sbin/nologin since on EL7 /sbin is a symlink to /usr/sbin, but that doesn't match packaging. Aligning this to packaging means there's one step that no longer needs to happen during installation. The parameter is not exposed in init.pp since most users won't care about this (in the past 6 years no PR has been submitted to do so).
ehelms
approved these changes
Jul 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Match the user shell to packaging
In dcb8a70 the shell was changed from /sbin/nologin to /bin/false since on Debian it is /usr/sbin/nologin.
Technically we can now always use /usr/sbin/nologin since on EL7 /sbin is a symlink to /usr/sbin, but that doesn't match packaging. Aligning this to packaging means there's one step that no longer needs to happen during installation.
The parameter is not exposed in init.pp since most users won't care about this (in the past 6 years no PR has been submitted to do so).
Make Foreman a system user and group
This matches what the RPM and Debian packages already do so it should have no effect in reality, but it does align the two.