Introduce a private socket_service helper #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekohl
force-pushed
the
service-socket-helper
branch
2 times, most recently
from
88e1353 to
fe0081e
Compare
ehelms
reviewed
May 26, 2021
| 'stopped' => false, | ||
| 'absent' => false, | ||
| default => undef, | ||
| } |
There was a problem hiding this comment.
I don't see present in the list but it is in the Enum of the parameter.
There was a problem hiding this comment.
That's what default is for. I agree it's a bit ugly, but puppet-lint wants a default statement and this is how I dealt with it.
ehelms
approved these changes
May 27, 2021
This ensures the correct dependency ordering. This is submitted to camptocamp/systemd but we're currently still on 2.x so no update will be available. This also helps with the move to 3.x.
ekohl
force-pushed
the
service-socket-helper
branch
from
fe0081e to
832a3a2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures the correct dependency ordering. This is submitted to camptocamp/systemd but we're currently still on 2.x so no update will be available. This also helps with the move to 3.x.
Submitting this now to see if it works in CI, then I can polish it up.