Support multiple path in environmentpath parameter #708
Comments
|
We can split it on |
|
Yes I can provide a patch, just need to agree on the implementation. Variables are currently not supported in there so it will not change current behaviour, right? The problem I can see is with $envs_target parameter where a 1:1 matching with $envs_dir might be confusing. |
|
Actually there are other references to which makes it not so easy to support multiple values with a single parameter.. |
|
To add on to this, I'm currently having an issue where my servers insist on creating the "common" environment and restarting puppetserver service, but my r10k runs remove this environment. Is there a way to disable the creating of this environment? |
|
You can set |
Thanks for the quick reply... What would happen if I just set it to:
|
|
That would work as well. |
This module adds support for the puppet environmentpath setting to be configured using multiple directories. An example use-case is where r10k is in use to deploy some but not all environments, to avoid unmanaged environments being purged by r10k. - Each listed environmentpath directory will be created and managed by puppet - The default post-receive hook script uses the first listed directory in `envs_dir` to create initial environments to maintain backward compatibility. - The config_version_cmd is updated to use only the first listed directory from `envs_dir`, this is only used in the environment.conf.erb template which does not appear to be deployed anywhere in the current version of this module Tests are included to ensure that all listed directories are created and managed, and that any other references to the envs_dir parameter behave the same as if only a single directory were specified to maintain backward compatibility. Fixes theforeman#708
|
I find myself wanting this functionality so that I can have r10k manage environments that have been committed to git, but also have some other environments present on the puppetserver which are not managed by r10k. r10k will purge unknown environments, and I don't believe this behaviour is configurable. One workaround is to have the puppetserver use two environmentpath directories, only one of which is managed by r10k, and the other contains the unmanaged environments. I have implemented support for One of the references to |
Looks like its use was removed in a61e010 and I forgot the actual template and parameter. I'd prefer to remove them and not get into the business of directly managing environments in this module. I'd also love a PR for this :) |
This module adds support for the puppet environmentpath setting to be configured using multiple directories. An example use-case is where r10k is in use to deploy some but not all environments, to avoid unmanaged environments being purged by r10k. - Each listed environmentpath directory will be created and managed by puppet - The default post-receive hook script uses the first listed directory in `envs_dir` to create initial environments to maintain backward compatibility. Tests are included to ensure that all listed directories are created and managed, and that any other references to the envs_dir parameter behave the same as if only a single directory were specified to maintain backward compatibility. Fixes theforeman#708
This module adds support for the puppet environmentpath setting to be configured using multiple directories. An example use-case is where r10k is in use to deploy some but not all environments, to avoid unmanaged environments being purged by r10k. Multiple directories are passed as an Array of Stdlib::Absolutepath values. For backwards compatibility, a single string is also accepted, and converted into a single-element array on each use. - Each listed environmentpath directory will be created and managed by puppet - The default post-receive hook script uses the first listed directory in `envs_dir` to create initial environments to maintain backward compatibility. Tests are included to ensure that all listed directories are created and managed, and that any other references to the envs_dir parameter behave the same as if only a single directory were specified to maintain backward compatibility. Fixes theforeman#708 Depends on theforeman#805
This module adds support for the puppet environmentpath setting to be configured using multiple directories. An example use-case is where r10k is in use to deploy some but not all environments, to avoid unmanaged environments being purged by r10k. Multiple directories are passed as an Array of Stdlib::Absolutepath values. For backwards compatibility, a single string is also accepted, and converted into a single-element array on each use. - Each listed environmentpath directory will be created and managed by puppet - The default post-receive hook script uses the first listed directory in `envs_dir` to create initial environments to maintain backward compatibility. Tests are included to ensure that all listed directories are created and managed, and that any other references to the envs_dir parameter behave the same as if only a single directory were specified to maintain backward compatibility. Fixes theforeman#708 Depends on theforeman#805
|
PR for dropping the I'm still seeing spec tests fail on cron resources, but I haven't touched anything relating to that, so I'm not sure why that's happening. Looking at previous commits, there seem to be various CI failures, though not relating to cron either. (Edit: master branch is also showing the cron failures, so definitely not related to the changes in my PRs) |
This module adds support for the puppet environmentpath setting to be configured using multiple directories. An example use-case is where r10k is in use to deploy some but not all environments, to avoid unmanaged environments being purged by r10k. - Each listed environmentpath directory will be created and managed by puppet - The default post-receive hook script uses the first listed directory in `envs_dir` to create initial environments to maintain backward compatibility. - The config_version_cmd is updated to use only the first listed directory from `envs_dir`, this is only used in the environment.conf.erb template which does not appear to be deployed anywhere in the current version of this module Tests are included to ensure that all listed directories are created and managed, and that any other references to the envs_dir parameter behave the same as if only a single directory were specified to maintain backward compatibility. Fixes theforeman#708
This module adds support for the puppet environmentpath setting to be configured using multiple directories. An example use-case is where r10k is in use to deploy some but not all environments, to avoid unmanaged environments being purged by r10k. Multiple directories are passed as an Array of Stdlib::Absolutepath values. For backwards compatibility, a single string is also accepted, and converted into a single-element array on each use. - Each listed environmentpath directory will be created and managed by puppet - The default post-receive hook script uses the first listed directory in `envs_dir` to create initial environments to maintain backward compatibility. Tests are included to ensure that all listed directories are created and managed, and that any other references to the envs_dir parameter behave the same as if only a single directory were specified to maintain backward compatibility. Fixes theforeman#708 Depends on theforeman#805
This module adds support for the puppet environmentpath setting to be configured using multiple directories. An example use-case is where r10k is in use to deploy some but not all environments, to avoid unmanaged environments being purged by r10k. Multiple directories are passed as an Array of Stdlib::Absolutepath values. For backwards compatibility, a single string is also accepted, and converted into a single-element array on each use. - Each listed environmentpath directory will be created and managed by puppet - The default post-receive hook script uses the first listed directory in `envs_dir` to create initial environments to maintain backward compatibility. Tests are included to ensure that all listed directories are created and managed, and that any other references to the envs_dir parameter behave the same as if only a single directory were specified to maintain backward compatibility. Fixes theforeman#708 Depends on theforeman#805
This module adds support for the puppet environmentpath setting to be configured using multiple directories. An example use-case is where r10k is in use to deploy some but not all environments, to avoid unmanaged environments being purged by r10k. Directories (whether one, or multiple) are passed as an Array of Stdlib::Absolutepath values. This is a breaking change, as a single string will no longer be accepted. - Each listed environmentpath directory will be created and managed by puppet - The default post-receive hook script uses the first listed directory in `envs_dir` to create initial environments to maintain backward compatibility. Tests are included to ensure that all listed directories are created and managed. Fixes theforeman#708 Depends on theforeman#805
This module adds support for the puppet environmentpath setting to be configured using multiple directories. An example use-case is where r10k is in use to deploy some but not all environments, to avoid unmanaged environments being purged by r10k. Directories (whether one, or multiple) are passed as an Array of Stdlib::Absolutepath values. This is a breaking change, as a single string will no longer be accepted. - Each listed environmentpath directory will be created and managed by puppet - The default post-receive hook script uses the first listed directory in `envs_dir` to create initial environments to maintain backward compatibility. Tests are included to ensure that all listed directories are created and managed. Fixes theforeman#708
This module adds support for the puppet environmentpath setting to be configured using multiple directories. An example use-case is where r10k is in use to deploy some but not all environments, to avoid unmanaged environments being purged by r10k. Directories (whether one, or multiple) are passed as an Array of Stdlib::Absolutepath values. This is a breaking change, as a single string will no longer be accepted. - Each listed environmentpath directory will be created and managed by puppet - The default post-receive hook script uses the first listed directory in `envs_dir` to create initial environments to maintain backward compatibility. Tests are included to ensure that all listed directories are created and managed. Fixes theforeman#708
This module adds support for the puppet environmentpath setting to be configured using multiple directories. An example use-case is where r10k is in use to deploy some but not all environments, to avoid unmanaged environments being purged by r10k. Directories (whether one, or multiple) are passed as an Array of Stdlib::Absolutepath values. This is a breaking change, as a single string will no longer be accepted. - Each listed environmentpath directory will be created and managed by puppet - The default post-receive hook script uses the first listed directory in `envs_dir` to create initial environments to maintain backward compatibility. Tests are included to ensure that all listed directories are created and managed. Fixes #708
Currently only one path is accepted. puppet.conf is correctly updated but it fails on folder creation. We probably need a loop at https://github.com/theforeman/puppet-puppet/blob/master/manifests/server/config.pp#L225
ref: https://puppet.com/docs/puppet/6.4/environments_creating.html#environmentpath
The text was updated successfully, but these errors were encountered: