add compile_mode parameter to puppetserver.conf #574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am not sure how could my simple change fail so many tests - will take a closer look at it, when I have the time. |
ekohl
requested changes
Jan 10, 2018
manifests/init.pp
Outdated
| @@ -725,6 +727,7 @@ | |||
| Optional[Array] $server_metrics_allowed = $::puppet::params::server_metrics_allowed, | |||
| Boolean $server_puppetserver_experimental = $puppet::params::server_puppetserver_experimental, | |||
| Array[String] $server_puppetserver_trusted_agents = $puppet::params::server_puppetserver_trusted_agents, | |||
| Variant[Undef, Enum['off'], Enum['jit'], Enum['force']] $server_compile_mode = $puppet::params::server_compile_mode, | |||
There was a problem hiding this comment.
This type can be Optional[Enum['off', 'jit', 'force']]
manifests/server.pp
Outdated
| @@ -449,6 +449,7 @@ | |||
| Variant[Undef, Array] $metrics_allowed = $::puppet::server_metrics_allowed, | |||
| Boolean $puppetserver_experimental = $::puppet::server_puppetserver_experimental, | |||
| Array[String] $puppetserver_trusted_agents = $::puppet::server_puppetserver_trusted_agents, | |||
| Variant[Undef, Enum['off'], Enum['jit'], Enum['force']] $compile_mode = $::puppet::server_compile_mode, | |||
theforeman-bot
added
Waiting on contributor
Needs re-review
Needs testing
and removed
Not yet reviewed
Waiting on contributor
labels
|
Looks correct, but I'll let Travis finish before approving. |
|
@ekohl I believe I named the variable incorrectly in the spec test, it should be called |
|
Problems fixed, commits squashed, please let me know if there's any more changes I should do. |
ekohl
approved these changes
Jan 11, 2018
|
looks good, merged, díky @miksercz! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
recently I wanted to try setting puppetserver's compile-mode to some value other than default, your module doesn't as of yet have this functionality. This PR should add it.