make foreman puppet module dir optional #600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is currently work in progress. I'm not sure yet if the tests pass and I also need to adjust the docs. @ekohl @mmoll feedback is highly appreciated :) I noticed that the module creates this directory. I never saw a foreman installation that uses this so I want to make it optional (or get rid of the exec at all). If there are usecases for the directory I will change the default from false to true. |
ekohl
reviewed
Jun 19, 2018
manifests/server/config.pp
Outdated
| exec { 'mkdir -p /usr/share/puppet/modules': | ||
| creates => '/usr/share/puppet/modules', | ||
| path => ['/usr/bin', '/bin'], | ||
| if ($puppet::server::create_foreman_modules_directory == true) { |
There was a problem hiding this comment.
I think we can avoid a parameter:
if '/usr/share/puppet/modules' in $puppet::server::common_modules_path {}
|
@ekohl I updated the code |
ekohl
requested changes
Jun 19, 2018
manifests/server/config.pp
Outdated
| exec { 'mkdir -p /usr/share/puppet/modules': | ||
| creates => '/usr/share/puppet/modules', | ||
| path => ['/usr/bin', '/bin'], | ||
| if ('/usr/share/puppet/modules' in $puppet::server::common_modules_path) { |
bastelfreak
changed the title
theforeman-bot
added
Needs re-review
Needs testing
and removed
Waiting on contributor
labels
ekohl
approved these changes
Jun 19, 2018
|
merged, danke @bastelfreak! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.