Use facter 3 facts during tests #636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You missed the systemd spec, see https://github.com/theforeman/puppet-puppet/pull/629/files#diff-7795d1e9a0843253185fbd796347dda7 |
alexjfisher
force-pushed
the
use_facter_3_facts
branch
from
173d113 to
3408c92
Compare
By default, rspec-puppet-facts uses the facterdb facts that match the version of the facter gem installed. Starting with facter 3, facter was no longer shipped as a gem (it was rewritten in C++). This commit sets `facterversion` to `3.0.0` so that tests run with more modern (structured) facts stubbed. Puppet has been shipping facter 3 since puppet 4.2.0. This module supports puppet >= 4.6.1, (and puppet 4 is EOL at the end of 2018). puppet-extlib's `ip_to_cron` function (used in puppet::agent::service::cron) has recently moved to using the `networking` structured fact not available in facter 2.
alexjfisher
force-pushed
the
use_facter_3_facts
branch
from
3408c92 to
3be3954
Compare
ekohl
approved these changes
Sep 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, rspec-puppet-facts uses the facterdb facts that match the
version of the facter gem installed. Starting with facter 3, facter
was no longer shipped as a gem (it was rewritten in C++).
This commit sets
facterversionto3.0.0so that tests run withmore modern (structured) facts stubbed.
Puppet has been shipping facter 3 since puppet 4.2.0. This module
supports puppet >= 4.6.1, (and puppet 4 is EOL at the end of 2018).
puppet-extlib's
ip_to_cronfunction (used inpuppet::agent::service::cron) has recently moved to using the
networkingstructured fact not available in facter 2.