Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manage connection timeout #677

Closed

Conversation

Edmilson-JR
Copy link
Contributor

PR as discussed at issue #676

@Edmilson-JR
Copy link
Contributor Author

@ekohl there was an intruder wrong comma

Already fixed it

@mmoll
Copy link
Contributor

mmoll commented Mar 31, 2019

@Edmilson-JR could you also remove configtimeout?

Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It'd be nice to drop configtimeout as well.

# $http_connect_timeout:: The maximum amount of time to wait (agent)
# when establishing an HTTP connection.
# Replaces 'configtimeout' along with
# 'http_read_timeout' (Puppet 4+).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The module is Puppet 5 only as of master so you can leave this out.

@ekohl
Copy link
Member

ekohl commented Apr 16, 2019

Replaced by #693

@ekohl ekohl closed this Apr 16, 2019
@Edmilson-JR
Copy link
Contributor Author

@ekohl sorry for the absence.

The last days was very complicated here.

Saw that #693 was merged.

Thank you.

@ekohl
Copy link
Member

ekohl commented Apr 16, 2019

We've all been there. Thanks for the initial PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants