Add server_ca_client_self_delete to CA Servers #728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the server_ca_client_self_delete boolean parameter to CA servers. When true, allows puppet clients to delete their own certificate from the Puppet CA.
|
Just to expand a little more, the use case for this feature for me was to allow for puppet agent certificate self renewal. I'm using the reidmv/puppet-module-puppet_certificate in particular to achieve this. Ideally auth.conf should be a little less static but this was the simpler commit for now. I've included a basic spec test. |
mmoll
reviewed
Mar 20, 2020
Spec test that checks config is not added with default parameters set.
|
merged, thanks @neilfromit! |
|
Awesome! Thanks for reviewing it. |
foxxx0
added a commit
to foxxx0/puppet-puppet
that referenced
this pull request
Jun 2, 2020
During theforeman#728 a regression was introduced, denying the other whitelisted admin clients cleaning/deletion of certificates: ``` 2020-06-02T16:30:47.856+02:00 ERROR [qtp1105504743-114201] [p.t.a.rules] Forbidden request: puppetserver01.[...] access to /puppet-ca/v1/certificate_status/my.fancy.hostname (method :delete) (authenticated: true) denied by rule 'Allow nodes to delete their own certificates'. ``` The solution is to re-allow the entries within `@server_admin_api_whitelist`, which usually contain "localhost" and the fqdn of the puppetserver CA system.
foxxx0
added a commit
to foxxx0/puppet-puppet
that referenced
this pull request
Jun 2, 2020
During theforeman#728 a regression was introduced, denying the other whitelisted admin clients cleaning/deletion of certificates: ``` 2020-06-02T16:30:47.856+02:00 ERROR [qtp1105504743-114201] [p.t.a.rules] Forbidden request: puppetserver01.[...] access to /puppet-ca/v1/certificate_status/my.fancy.hostname (method :delete) (authenticated: true) denied by rule 'Allow nodes to delete their own certificates'. ``` The solution is to re-allow the entries within `@server_admin_api_whitelist`, which usually contain "localhost" and the fqdn of the puppetserver CA system.
ekohl
pushed a commit
that referenced
this pull request
Jun 10, 2020
During #728 a regression was introduced, denying the other whitelisted admin clients cleaning/deletion of certificates: ``` 2020-06-02T16:30:47.856+02:00 ERROR [qtp1105504743-114201] [p.t.a.rules] Forbidden request: puppetserver01.[...] access to /puppet-ca/v1/certificate_status/my.fancy.hostname (method :delete) (authenticated: true) denied by rule 'Allow nodes to delete their own certificates'. ``` The solution is to re-allow the entries within `@server_admin_api_whitelist`, which usually contain "localhost" and the fqdn of the puppetserver CA system.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the server_ca_client_self_delete boolean parameter to CA servers.
When true, allow puppet clients to delete their own certificate from
the Puppet CA.