Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add server_trusted_external_command parameter #731

Merged
merged 1 commit into from
Apr 2, 2020

Conversation

baurmatt
Copy link
Contributor

Make it possible to configure the 'trusted_external_command' parameter.
https://puppet.com/docs/puppet/latest/configuration.html#trustedexternalcommand

Fixes #730.

@mmoll
Copy link
Contributor

mmoll commented Mar 31, 2020

👍 code wise, however, I think it would be nice to limit its use to new enough Puppet versions.

@baurmatt
Copy link
Contributor Author

baurmatt commented Apr 1, 2020

As the defaut ist false I'm not sure if that is required given that the documentation clearly states that this feature is for Puppet > 6.11. What exactly do you have in mind? :) Just fail if server_trusted_external_command is given for < 6.11? :)

@mmoll
Copy link
Contributor

mmoll commented Apr 1, 2020

Just fail if server_trusted_external_command is given for < 6.11? :)

It might be a bit harsh, but I guess it's the right thing, as just going over it on older clients might give a false sense of the state the environment is put into.

@mmoll mmoll merged commit 8c58834 into theforeman:master Apr 2, 2020
@mmoll
Copy link
Contributor

mmoll commented Apr 2, 2020

merged, danke @baurmatt!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add trusted_external_command parameter
4 participants