Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to puppetserver_foreman #749

Merged
merged 1 commit into from
Apr 6, 2021

Conversation

ekohl
Copy link
Member

@ekohl ekohl commented Jun 24, 2020

The Foreman integration bits are being split out to their own module. This changes over the integration.

Depends on theforeman/puppet-puppetserver_foreman#1

@ekohl ekohl force-pushed the move-to-puppetserver_foreman branch from 3e39886 to 315edae Compare March 10, 2021 11:57
@ekohl ekohl force-pushed the move-to-puppetserver_foreman branch from 315edae to 2d4e912 Compare March 30, 2021 16:56
@ekohl ekohl marked this pull request as ready for review March 30, 2021 16:56
The Foreman integration bits are being split out to their own module.
This changes over the integration.
@ekohl ekohl force-pushed the move-to-puppetserver_foreman branch from 2d4e912 to 97319a9 Compare March 31, 2021 07:16
@ekohl
Copy link
Member Author

ekohl commented Mar 31, 2021

I believe this is now ready to merge.

Copy link
Member

@ehelms ehelms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are the test failures expected?

@ekohl
Copy link
Member Author

ekohl commented Apr 1, 2021

Yes:

  • CentOS 6 fails because the yum repos are gone
  • Debian 10 + Puppet 5 fails because there are no Puppet 5 packages on Debian 10
  • Same for Ubuntu 20.04 + Puppet 5

@ekohl ekohl merged commit c64b896 into theforeman:master Apr 6, 2021
@ekohl ekohl deleted the move-to-puppetserver_foreman branch April 6, 2021 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants