Add server_puppetserver_trusted_certificate_extensions
#758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexjfisher
force-pushed
the
trusted_certificate_extensions
branch
2 times, most recently
from
04e60aa to
0d5be00
Compare
alexjfisher
changed the title
alexjfisher
changed the title
server_puppetserver_trusted_certificate_extensions
|
Can this get a review? (I was messaged on Puppet Community slack today. @chadh is planning PRs in the same area). |
ekohl
reviewed
Oct 7, 2020
Comment on lines
+15
to
+21
| <%= scope.call_function( | ||
| 'to_json_pretty', | ||
| [ | ||
| {'allow' => @server_trusted_agents + ['$1'] + @server_trusted_certificate_extensions.map { |extension| { 'extensions' => extension } } } | ||
| ] | ||
| ).lines.to_a[1..-2].map{ |line| " #{line}"}.join | ||
| -%> |
There was a problem hiding this comment.
We migrated away from puppetlabs-hocon because puppetlabs-hocon because back then the support wasn't really clear. Looking at how they still update it I do wonder if we should reconsider. However, probably better to merge it now.
There was a problem hiding this comment.
I think it'd be much easier for users to add their own configs in their profiles if it still did use puppetlabs-hocon
alexjfisher
force-pushed
the
trusted_certificate_extensions
branch
from
0d5be00 to
f6e75c6
Compare
ekohl
reviewed
Oct 9, 2020
Accepts an array of hashes to allow for more complicated setups.
Typical use would probably just be a single array element such as...
```puppet
class { 'puppet':
...
server_puppetserver_trusted_certificate_extensions => [{ 'pp_authorization' => 'catalog' }],
...
}
```
alexjfisher
force-pushed
the
trusted_certificate_extensions
branch
from
f6e75c6 to
d43fbee
Compare
ekohl
approved these changes
Oct 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Accepts an array of hashes to allow for more complicated setups.
Typical use would probably just be a single array element such as...