adds param for user-provided puppetserver auth.conf #769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekohl
reviewed
Oct 7, 2020
chadh
force-pushed
the
puppetserver_auth_template
branch
2 times, most recently
from
7111d1f to
7dcbc12
Compare
ekohl
reviewed
Oct 8, 2020
chadh
force-pushed
the
puppetserver_auth_template
branch
from
7dcbc12 to
75b3b30
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a lot of special use cases for auth.conf, and rather than 100% manage that file, this PR gives the module user a way to provide their own. Ideally we would use an epp template and also provide a hash of arguments for the template , but I tried to just match the existing pattern in this PR. This potentially address #752 .