Permit setting default_schedules to true
#852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The CI failures don't appear to be related to my changes.... I'm not sure which redmine project to file this under.... |
jcpunk
force-pushed
the
default_schedules
branch
from
097c9c0 to
67386dd
Compare
Technically not required, but https://projects.theforeman.org/projects/puppet-foreman if you want to. |
ekohl
approved these changes
Jan 11, 2023
jcpunk
force-pushed
the
default_schedules
branch
from
67386dd to
d5a4079
Compare
|
I've tried to link up to https://projects.theforeman.org/issues/35932 |
ekohl
requested changes
Jan 12, 2023
Also allow override for `localconfig`, but I don't know why someone would change it....
jcpunk
force-pushed
the
default_schedules
branch
from
d5a4079 to
99ecb2c
Compare
|
I think I've got the commit line sorted now. |
ekohl
approved these changes
Jan 12, 2023
There was a problem hiding this comment.
Yes indeed. You can see https://github.com/theforeman/puppet-puppet/pull/852/checks?check_run_id=10608471594 now shows a link to the right issue and the Redmine issue was flipped to Ready For Testing with a link to this PR. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also allow override for
localconfig, but I don't know why someone would change it....I've been using the default schedules for a few things and, while I get not everyone likes them, I'd like to be able to keep using them.
Without this flag, this module is mostly useless for my environment.