Fixes #35943 - Switch to puppetlabs vcsrepo for gitrepo tracking #860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekohl
reviewed
Jan 13, 2023
ekohl
reviewed
Jan 13, 2023
There was a problem hiding this comment.
We'll also want to update our installer to pull in puppetlabs/vcsrepo instead of theforeman/git. Today we have this line:
Since it's an external module there is no need to pull it from git. I'd prefer to use a forge release instead.
You can use Refs #35943 in that PR to relate the two.
|
I do not understand those test failures... |
|
You forgot some expectations. The stackstrace is hard to read but |
|
Ok I think it is sorted again... that ubuntu failure looks like a docker issue... |
ekohl
approved these changes
Aug 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR switches to using the
puppetlabs/vcsrepomodule. In theory this should reduce the maintenance overhead of this module forgitrelated issues.