-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Puppet 8 support #884
Add Puppet 8 support #884
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requires #888
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please rebase
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Our upgrade test requires versions to be set:
puppet-puppet/spec/acceptance/puppetserver_upgrade_spec.rb
Lines 17 to 23 in 012b369
case ENV['BEAKER_PUPPET_COLLECTION'] | |
when 'puppet7' | |
from_version = '7.6.0' | |
to_version = '7.13.0' | |
else | |
raise 'Unsupported Puppet collection' | |
end |
We pick the oldest and newest versions that are available for all the platforms.
I took the liberty of adding to your PR, hopefully to move things forward. |
also contains #883