-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Manage more parameters extension #141
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for picking this up.
Would you mind rebasing instead of merging? |
dcbdc47
to
c20b1ad
Compare
I fixed the mess I made in the commits and rebased. |
c20b1ad
to
8030ed5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps port listening in acceptance tests can be properly tested now that the service always runs.
Included in 64de477 |
64de477
to
5bb987f
Compare
4544fd7
to
e9715f4
Compare
I'm sorry we didn't get to work this out at cfgmgmtcamp, but I've taken the liberty to rebase your commits and force push it. Checking what CI says now. |
e9715f4
to
8ffb6e4
Compare
Hi, thanks for remembering! I was...too tired..after Mondays evening to produce any values. We have to address one more thing that I realized while using the proposed changes. For RHEL - the tftp.socket service is running all the time (as it should), but tftp.service deactivates itself after 15 minutes without receiving any reguests. If requests come it (tftp.socket) keeps the tftp.service running or starts it. If the tftp.service is exited, then Puppet starts the service and the whole cycle continues. We manage both services (and ensure=running) to be able to reliably reload the service when the config file of the service is changed. Any tips how to solve this on the Puppet level, or should I look into the config of tftp.service if its possible to keep it running without the 15min "TTL" ? |
Extends #115