Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manage more parameters extension #141

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

dvo-rak
Copy link

@dvo-rak dvo-rak commented Sep 14, 2023

Extends #115

Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for picking this up.

data/Debian.yaml Outdated Show resolved Hide resolved
data/RedHat.yaml Outdated Show resolved Hide resolved
templates/tftp.service-override.epp Outdated Show resolved Hide resolved
metadata.json Outdated Show resolved Hide resolved
@ekohl
Copy link
Member

ekohl commented Sep 18, 2023

Would you mind rebasing instead of merging?

@dvo-rak dvo-rak force-pushed the manage-more-parameters branch 3 times, most recently from dcbdc47 to c20b1ad Compare September 19, 2023 09:03
@dvo-rak
Copy link
Author

dvo-rak commented Sep 19, 2023

Would you mind rebasing instead of merging?

I fixed the mess I made in the commits and rebased.

@dvo-rak dvo-rak force-pushed the manage-more-parameters branch from c20b1ad to 8030ed5 Compare September 19, 2023 09:11
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps port listening in acceptance tests can be properly tested now that the service always runs.

spec/acceptance/tftp_port_spec.rb Outdated Show resolved Hide resolved
spec/acceptance/tftp_port_spec.rb Outdated Show resolved Hide resolved
@dvo-rak
Copy link
Author

dvo-rak commented Sep 21, 2023

Perhaps port listening in acceptance tests can be properly tested now that the service always runs.

Included in 64de477

@dvo-rak dvo-rak force-pushed the manage-more-parameters branch from 64de477 to 5bb987f Compare October 3, 2023 09:24
@ekohl ekohl force-pushed the manage-more-parameters branch from 4544fd7 to e9715f4 Compare February 13, 2024 17:35
@ekohl
Copy link
Member

ekohl commented Feb 13, 2024

I'm sorry we didn't get to work this out at cfgmgmtcamp, but I've taken the liberty to rebase your commits and force push it. Checking what CI says now.

@ekohl ekohl force-pushed the manage-more-parameters branch from e9715f4 to 8ffb6e4 Compare February 13, 2024 19:43
@dvo-rak
Copy link
Author

dvo-rak commented Feb 13, 2024

Hi, thanks for remembering! I was...too tired..after Mondays evening to produce any values.

We have to address one more thing that I realized while using the proposed changes.

For RHEL - the tftp.socket service is running all the time (as it should), but tftp.service deactivates itself after 15 minutes without receiving any reguests. If requests come it (tftp.socket) keeps the tftp.service running or starts it. If the tftp.service is exited, then Puppet starts the service and the whole cycle continues. We manage both services (and ensure=running) to be able to reliably reload the service when the config file of the service is changed.

Any tips how to solve this on the Puppet level, or should I look into the config of tftp.service if its possible to keep it running without the 15min "TTL" ?

@ekohl ekohl mentioned this pull request Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants