Fixes #12574 - Upgrade rubocop to 0.35.1 #346
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The rubocop test is failing as it seems to be crashing on one of our source files. I think it should be filed as a bug against rubocop, and then we can either workaround it by excluding the code with a rubocop comment or config file. An error occurred while Style/StabbyLambdaParentheses cop was inspecting /home/dcleal/code/foreman/smart-proxy/modules/puppet_proxy/class_scanner_eparser.rb. undefined method `children' for :do_find:Symbol /home/dcleal/.rvm/gems/ruby-2.1.0@proxy/gems/rubocop-0.35.1/lib/rubocop/cop/style/stabby_lambda_parentheses.rb:98:in `args?' /home/dcleal/.rvm/gems/ruby-2.1.0@proxy/gems/rubocop-0.35.1/lib/rubocop/cop/style/stabby_lambda_parentheses.rb:83:in `lambda_with_args?' /home/dcleal/.rvm/gems/ruby-2.1.0@proxy/gems/rubocop-0.35.1/lib/rubocop/cop/style/stabby_lambda_parentheses.rb:27:in `on_send' Edit: seems it's interpreting our |
|
Filed as rubocop/rubocop#2451. |
doesn't work in this case, it still errs. disabled in |
|
Merged in 45ba025. Thanks, @brandonweeks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same thing as theforeman/foreman#2924