Devel #8
Merged
Devel #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On the sell side, don't cancel furthest orders ever, instead just place closer sell order using available (not allocated) funds. If target spread still not reached, cancel furthest buy side order. Closes: #443
Default expiration time of 30 seconds may be too low in some cases (slow connection, time differences between local machine and the node). Also, time to irreversible block is more than 30 seconds. In case of chain microforks a node can recover transactions from shorter chain if they are not expired yet. E.g., with bigger expiration trx inclusion in irreversible block is more reliable.
Trx expiration must fit into limit "head block time + 1 day". If it's not, the node is not properly synced (blockchain state) or client machine time is too much in the future. As a solution, try to switch node, and if it didn't help raise error to the user. Closes: #250
When returning an order, invert() must be called not only when deleted order is reconstructed, but in normal case too. Don't invert by default as it may break backward compatibility.
Uncheck reset_on_price_change when center_price_dynamic set to False. This prevents setting of bad options combination, thus avoiding further error.
If order was filled partially it may stay as a dust order. Instead of waiting until it will be fully filled, just cancel it and use obtained funds to place closer order on opposite side. Closes: #432
Closes: #497
* edit market offered to end user as QUOTE/BASE instead of vice versa * edit default value to use / as separator * switch pair order * allow numerics in symbols
…wif key to config
…to thehapax-458-refactor-cli-configure During merge following merge conflicts were resolved: Conflicts: dexbot/cli_conf.py dexbot/strategies/base.py dexbot/ui.py
Added PEP8 testing to the MakeFile which does the following: 1. Installs Flake8 3.7.7 with dependencies 2. Runs flake8 test for dexbot folder 3. Uninstalls Flake8 with dependencies so that the project's build does not grow too much in size
Runs pep-test before building
Includes the max line length of 120 and excludes some auto generated python files
Moved all the pip install packages on one line and fixed the package installation
- Removed unused imports - Changed 'dexbot.helper' import to be more specific - Fixed 'os' import, since it doesn't come from 'dexbot.helper' anymore
Added some missing new lines from end of the files and removed one extra
Added tests/ folder to lint and pep-test, since this was missing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
into thehapax master