Fixed #5500: implemented "Toggle Minimap" command

[fangnx]

• Implemented the "Toggle Minimap" command in the command pallete.

[vince-fugnitto]

It works well!
I'd be fine too if the method doToggleMinimap was simply called toggleMinimap, and more description was made in the method to describe that it updates the user editor.minimap.enabled preference.

[vince-fugnitto]

@lmcbout can you try it out as well? Note that the command only updates the User preference.
If the preference already exists at the workspace or folder level it takes precedence over the toggle.

[lmcbout]

@lmcbout can you try it out as well? Note that the command only updates the User preference.
If the preference already exists at the workspace or folder level it takes precedence over the toggle.

1- Code should be modify from doToggleMinimap() to toggleMinimap() as suggested
2- When the 'editor.minimap.enabled' is defined in the workspace, it takes over and nothing happen. If you want to have the same behavior as VSCode, VSCode show/hide the minimap even when it is defined at the workspace level, so considerating this, it does not work. Do we want to show/hide the minimap if this preferences is defined at a lower level ?

[vince-fugnitto]

2- When the 'editor.minimap.enabled' is defined in the workspace, it takes over and nothing happen. If you want to have the same behavior as VSCode, VSCode show/hide the minimap even when it is defined at the workspace level, so considerating this, it does not work. Do we want to show/hide the minimap if this preferences is defined at a lower level ?

@lmcbout

We have the same behaviour as VSCode.

VSCode sets the User preference only for the editor.minimap.enabled preference.
If the preference is set at the Workspace level it takes precedence over the User.

I do not believe there is anything more to do in this PR, and this comment was already discussed #5633 (comment)

And looking at their source code you can see as well we implement it similarly:
https://github.com/microsoft/vscode/blob/7bc29bf67c17608b11e23a8497c8f1de5a0922cf/src/vs/workbench/contrib/codeEditor/browser/toggleMinimap.ts#L26-L29

[lmcbout]

Would be nice, but not mandatory: doToggleMinimap() to toggleMinimap() as suggested
After further investigation, VSCode behave the same. As long as you don't put the preference in the workspace level, it is fine. VSCode put as default "true" in the workspace .
LGTM

[fangnx]

Would be nice, but not mandatory: doToggleMinimap() to toggleMinimap() as suggested
After further investigation, VSCode behave the same. As long as you don't put the preference in the workspace level, it is fine. VSCode put as default "true" in the workspace .
LGTM

I will change the naming ;). Thanks for the feedback!

---

Just fixed the naming issue. @vince-fugnitto