Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimise PC regression #408

Merged
merged 28 commits into from
Dec 20, 2024
Merged

Optimise PC regression #408

merged 28 commits into from
Dec 20, 2024

Conversation

mumichae
Copy link
Collaborator

No description provided.

@codecov Codecov
Copy link

codecov bot commented Apr 22, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 86.15385% with 9 lines in your changes missing coverage. Please review.

Project coverage is 58.93%. Comparing base (d357273) to head (c54ad5c).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
scib/metrics/pcr.py 84.48% 9 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #408      +/-   ##
==========================================
+ Coverage   58.01%   58.93%   +0.91%     
==========================================
  Files          22       22              
  Lines        1646     1690      +44     
==========================================
+ Hits          955      996      +41     
- Misses        691      694       +3
Flag Coverage Δ
unittests 58.93% <86.15%> (+0.91%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
scib/metrics/cell_cycle.py 89.58% <100.00%> (+0.22%) ⬆️
scib/preprocessing.py 19.06% <100.00%> (ø)
scib/metrics/pcr.py 85.71% <84.48%> (+4.55%) ⬆️

@mumichae mumichae requested a review from VladimirShitov April 24, 2024 12:56
VladimirShitov
VladimirShitov approved these changes Apr 24, 2024
View reviewed changes
Copy link
Collaborator

@VladimirShitov VladimirShitov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, looks super nice. Sometimes, the code is unclear. I left some comments on potential improvements :)

scib/metrics/pcr.py Outdated Show resolved Hide resolved
scib/metrics/pcr.py Outdated Show resolved Hide resolved
scib/metrics/pcr.py Show resolved Hide resolved
tests/metrics/test_pcr_metrics.py Show resolved Hide resolved
VladimirShitov
VladimirShitov approved these changes Apr 26, 2024
View reviewed changes
Copy link
Collaborator

@VladimirShitov VladimirShitov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me :)

VladimirShitov
VladimirShitov approved these changes Dec 5, 2024
View reviewed changes
Copy link
Collaborator

@VladimirShitov VladimirShitov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in general :) I left a few questions

scib/metrics/pcr.py Outdated Show resolved Hide resolved
scib/metrics/pcr.py Show resolved Hide resolved
tests/metrics/test_beyond_label_metrics.py Show resolved Hide resolved
scib/metrics/cell_cycle.py Outdated Show resolved Hide resolved
mumichae
mumichae commented Dec 10, 2024
View reviewed changes
Copy link
Collaborator Author

@mumichae mumichae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I addressed your comments, but only changed the linear regression part to use multiple regression. According to my tests the output is sufficiently similar

scib/metrics/pcr.py Show resolved Hide resolved
tests/metrics/test_beyond_label_metrics.py Show resolved Hide resolved
scib/metrics/pcr.py Outdated Show resolved Hide resolved
scib/metrics/pcr.py Show resolved Hide resolved
scib/metrics/cell_cycle.py Outdated Show resolved Hide resolved
@mumichae mumichae merged commit e614d35 into main Dec 20, 2024
10 checks passed
@mumichae mumichae deleted the optimise_pcr branch December 20, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VladimirShitov VladimirShitov VladimirShitov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mumichae @VladimirShitov