7zip fails with zip file where files in the central directory header don't flag UNKNOWN_CRC32_AND_FILE_SIZES #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice pull request. It looks like your changes are actually more conformant to the spec than my code. Hard to believe; I thought I'd really did my research reading the spec. Nice work. Tested unzipping with Linux InfoZip, Windows Compressed Folder, 7-Zip 9.20, 7-Zip 9.38, Mac Archive Utility. |
thejoshwolfe
added a commit
that referenced
this pull request
May 7, 2015
7zip fails with zip file where files in the central directory header don't flag UNKNOWN_CRC32_AND_FILE_SIZES
|
yazl 2.2.2 published. Let me know if you have any other issues, and thanks again for your contribution. |
|
Thanks for integrating the pull request so quickly. And thanks a lot for implementing yazl and yauzl. Makes our lives a lot easier. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you add entries to a zip using a stream the crc and sizes aren't know. 7Zip fails validating and extracting such a zip file if the UNKNOWN_CRC32_AND_FILE_SIZES isn't part of the central directory header as well.