Add annotation to prevent uninstalling helm chart of Job/App #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes we want to remove App/Job CR but keep their helm chart running, it is a kind of soft self-uninstalling) To handle this use-case, ketch-controller looks for theketch.io/dont-uninstall-helm-chart=true annotation. If it is present on an App/Job CR and kuberentes has marked the CR for deletion, ketch controller doesn't uninstall its helm chart.
DavisFrench
approved these changes
Feb 4, 2022
stinkyfingers
approved these changes
Feb 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes we want to remove App/Job CR but keep their helm chart
running, it is kind of soft self-uninstalling)
To handle this use-case, ketch-controller checks for
theketch.io/dont-uninstall-helm-chart=trueannotation.If it is present on an App/Job CR and kuberentes has marked the CR for deletion,
ketch controller doesn't uninstall its helm chart.