Skip to content

Commit

Permalink
Fix CFs list broken display in repairs and schedule views. (#107)
Browse files Browse the repository at this point in the history
  • Loading branch information
anguenot authored and michaelsembwever committed Jun 27, 2017
1 parent 5ac5fbd commit 3906a01
Show file tree
Hide file tree
Showing 7 changed files with 55 additions and 39 deletions.
12 changes: 12 additions & 0 deletions reaper_ui/app/jsx/mixin.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -80,3 +80,15 @@ export const DeleteStatusMessageMixin = {
}

};

export const CFsListRender = React.createClass({
render: function() {
return (
<ul>
{this.props.list.map(function(listValue){
return <li>{listValue}</li>;
})}
</ul>
)
}
});
5 changes: 2 additions & 3 deletions reaper_ui/app/jsx/repair-list.jsx
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
import React from "react";
import moment from "moment";
import {RowDeleteMixin, RowAbortMixin, StatusUpdateMixin, DeleteStatusMessageMixin} from "jsx/mixin";

import {RowDeleteMixin, RowAbortMixin, StatusUpdateMixin, DeleteStatusMessageMixin, CFsListRender} from "jsx/mixin";

const TableRow = React.createClass({
mixins: [RowDeleteMixin, StatusUpdateMixin, RowAbortMixin],
Expand All @@ -23,7 +22,7 @@ const TableRow = React.createClass({
<td data-toggle="collapse" data-target={rowID}>{this.props.row.state}</td>
<td data-toggle="collapse" data-target={rowID}>{this.props.row.cluster_name}</td>
<td data-toggle="collapse" data-target={rowID}>{this.props.row.keyspace_name}</td>
<td data-toggle="collapse" data-target={rowID}>{this.props.row.column_families}</td>
<td data-toggle="collapse" data-target={rowID}><CFsListRender list={this.props.row.column_families} /></td>
<td data-toggle="collapse" data-target={rowID}>{incremental}</td>
<td data-toggle="collapse" data-target={rowID}>
<div className="progress">
Expand Down
5 changes: 2 additions & 3 deletions reaper_ui/app/jsx/schedule-list.jsx
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
import React from "react";
import moment from "moment";
import {RowDeleteMixin, StatusUpdateMixin, DeleteStatusMessageMixin} from "jsx/mixin";

import {RowDeleteMixin, StatusUpdateMixin, DeleteStatusMessageMixin, CFsListRender} from "jsx/mixin";

const TableRow = React.createClass({
mixins: [RowDeleteMixin, StatusUpdateMixin],
Expand Down Expand Up @@ -54,7 +53,7 @@ const TableRowDetails = React.createClass({
</tr>
<tr>
<td>CFs</td>
<td>{this.props.row.column_families}</td>
<td><CFsListRender list={this.props.row.column_families} /></td>
</tr>
<tr>
<td>Incremental</td>
Expand Down
32 changes: 16 additions & 16 deletions src/main/resources/assets/deps.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion src/main/resources/assets/index.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

19 changes: 11 additions & 8 deletions src/main/resources/assets/repair.js

Large diffs are not rendered by default.

19 changes: 11 additions & 8 deletions src/main/resources/assets/schedules.js

Large diffs are not rendered by default.

0 comments on commit 3906a01

Please sign in to comment.