Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI parallelism options don't match Cassandra #32

Closed
corey-cole opened this issue Dec 14, 2016 · 3 comments
Closed

UI parallelism options don't match Cassandra #32

corey-cole opened this issue Dec 14, 2016 · 3 comments
Labels

Comments

@corey-cole
Copy link

The UI stores the string description value of the parallelism option when creating a repair, but when Reaper tries to retrieve the repair from the database, it fails with the following stack trace:

ERROR [2016-12-14 20:13:30,824] [dw-22 - GET /repair_run] i.d.j.e.LoggingExceptionMapper - Error handling a request: 18b1eccefcda9f42 java.lang.IllegalArgumentException: No enum constant org.apache.cassandra.repair.RepairParallelism.parallel at java.lang.Enum.valueOf(Enum.java:238) ~[na:1.8.0_102] at org.apache.cassandra.repair.RepairParallelism.valueOf(RepairParallelism.java:26) ~[cassandra-reaper-0.3.2-SNAPSHOT.jar:0.3.2-SNAPSHOT] at com.spotify.reaper.storage.postgresql.RepairRunMapper.map(RepairRunMapper.java:41) (deleted the rest)

I can (temporarily) get the repair in the database to appear in the UI by changing the value in repair_run.repair_parallelism to the enumeration name (e.g. PARALLEL instead of parallel).

This is reaper 0.3.2 against Cassandra 2.25 using Postgres as a storage backend.

adejanovski added a commit that referenced this issue Dec 15, 2016
@adejanovski
Copy link
Contributor

Hi @corey-cole,

branch fix-issue-32 should fix the issue by using fromName() instead of valueOf() to match the value to the enum constant when using postgres as storage backend.

Let us know if that fixes your issue, so that we can merge the fix into master.

Thanks

adejanovski added a commit that referenced this issue Dec 15, 2016
Add build instructions in README
Bump up version to 0.3.3
@corey-cole
Copy link
Author

That did the trick. Thanks for the quick fix.

adejanovski added a commit that referenced this issue Dec 15, 2016
)

Add build instructions in README
Bump up version to 0.3.3
@adejanovski
Copy link
Contributor

Thanks for the feedback, I've merged the associated PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants