-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docker compose environment #136
Conversation
# create the required reaper_db keyspace to allow Reaper to store scheduling data | ||
CMD set -x \ | ||
&& cqlsh cassandra -e \ | ||
"CREATE KEYSPACE IF NOT EXISTS reaper_db WITH replication = {'class': 'SimpleStrategy', 'replication_factor': 1 };" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we should be assuming RF=1 anywhere.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this RF (i presume) it only for the one-node-cassandra within the docker container.
Maybe it's the applicaton's responsibility to log a warning at startup if RF=1 and N>1
wdyt?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 on having an application logging if the RF is set lower than expected.
@joaquincasares you can't merge master into branches. Branches (that are intended for master) must be rebased off master. |
I don't think it's related to this PR, but
|
Fails for me on (Mac OS X). You are right @michaelsembwever it is unrelated because I see the same problem on the master branch. |
The docker commands now work for me! (a couple of local pax issues i had to overcome) |
01c939a
to
81d42b1
Compare
|
i've solved this, it was a local issue around PaX controls. |
This PR is dependent on #135.
This is the last PR in an effort to to deprecate #46.
This adds a sample Cassandra node, including all the required settings and Docker Compose services in order to run Reaper in a clean and isolated environment with the only dependencies being Docker and Docker Compose.
I've also included a semi-lengthy, in-depth view of Docker Compose infrastructure within
./docker/README.md
. At the end of this README, are instructions for how to run Dockerized Reaper within production environments.