For Cassandra storage minimise the number of tombstones (NULL entries) in the repair_run table #244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The changes in CassandraStorage form the crux of the patch. |
michaelsembwever
force-pushed
the
mck/cassandra-minimise-repair-run-tombstones
branch
from
b793304 to
f58665a
Compare
michaelsembwever
added a commit
that referenced
this pull request
Oct 19, 2017
…) in the repair_run table. Remove RepairSegment.repairCommandId as no one was using/storing it. Make explicit which fields in RepairSegment can be null and be nulled. Hide the RepairSegment.Builder constructor. Add Preconditions and asserts in ensuring lifecycle state is correct and null fields only exist as/when appropriate. Preconditions are used when fast and providing fail-fast design. Asserts are used where expensive and/or are secondary checks. ref: - #240 - #244
michaelsembwever
force-pushed
the
mck/cassandra-minimise-repair-run-tombstones
branch
from
f58665a to
6322293
Compare
michaelsembwever
added a commit
that referenced
this pull request
Oct 19, 2017
…) in the repair_run table. Remove RepairSegment.repairCommandId as no one was using/storing it. Make explicit which fields in RepairSegment can be null and be nulled. Hide the RepairSegment.Builder constructor. Add Preconditions and asserts in ensuring lifecycle state is correct and null fields only exist as/when appropriate. Preconditions are used when fast and providing fail-fast design. Asserts are used where expensive and/or are secondary checks. ref: - #240 - #244
|
the joy of codebases that don't treat nulls explicitly… :-/ |
michaelsembwever
force-pushed
the
mck/cassandra-minimise-repair-run-tombstones
branch
from
6322293 to
091403b
Compare
michaelsembwever
added a commit
that referenced
this pull request
Oct 19, 2017
…) in the repair_run table. Remove RepairSegment.repairCommandId as no one was using/storing it. Make explicit which fields in RepairSegment can be null and be nulled. Hide the RepairSegment.Builder constructor. Add Preconditions and asserts in ensuring lifecycle state is correct and null fields only exist as/when appropriate. Preconditions are used when fast and providing fail-fast design. Asserts are used where expensive and/or are secondary checks. ref: - #240 - #244
adejanovski
approved these changes
Oct 19, 2017
michaelsembwever
force-pushed
the
mck/cassandra-minimise-repair-run-tombstones
branch
from
091403b to
dec813f
Compare
michaelsembwever
added a commit
that referenced
this pull request
Oct 19, 2017
…) in the repair_run table. Remove RepairSegment.repairCommandId as no one was using/storing it. Make explicit which fields in RepairSegment can be null and be nulled. Hide the RepairSegment.Builder constructor. Add Preconditions and asserts in ensuring lifecycle state is correct and null fields only exist as/when appropriate. Preconditions are used when fast and providing fail-fast design. Asserts are used where expensive and/or are secondary checks. ref: - #240 - #244
|
Last change most probably fixed the issue with the race condition between the JMX success notification and the abort of leaderless segments. Let's go ahead and merge. |
…) in the repair_run table. Remove RepairSegment.repairCommandId as no one was using/storing it. Make explicit which fields in RepairSegment can be null and be nulled. Hide the RepairSegment.Builder constructor. Re-read segments once leader-election is done, ensuring we're not writing back stale data Add Preconditions and asserts in ensuring lifecycle state is correct and null fields only exist as/when appropriate. Preconditions are used when fast and providing fail-fast design. Asserts are used where expensive and/or are secondary checks. ref: - #240 - #244
michaelsembwever
force-pushed
the
mck/cassandra-minimise-repair-run-tombstones
branch
from
dec813f to
03b6663
Compare
michaelsembwever
deleted the
mck/cassandra-minimise-repair-run-tombstones
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove RepairSegment.repairCommandId as no one was using/storing it.
Make explicit which fields in RepairSegment can be null and be nulled.
Hide the RepairSegment.Builder constructor.
Add Preconditions and asserts in ensuring lifecycle state is correct and null fields only exist as/when appropriate.
Preconditions are used when checks are fast and for providing fail-fast design. Asserts are used where checks are expensive and/or are secondary checks.
ref: #240