Handle new messaging service verbs for dropped reads in Cassandra 4.0 #714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| List<DroppedMessages> tpstats = SimpleReaperClient.parseDroppedMessagesJSON(responseData); | ||
|
|
||
| long readDroppedTotal = tpstats.stream() | ||
| .filter(tpstat -> "READ".equals(tpstat.getName()) || "READ_REQ".equals(tpstat.getName())) |
There was a problem hiding this comment.
this line and line 1606 is the core of the PR
| .filter(tpstat -> tpstat.getCount() >= 0) | ||
| .count(); | ||
| long readDroppedCount = tpstats.stream() | ||
| .filter(tpstat -> "READ".equals(tpstat.getName()) || "READ_REQ".equals(tpstat.getName()) ) |
There was a problem hiding this comment.
this line and line 1602 is the core of the PR
michaelsembwever
force-pushed
the
mck/fix-cassandra-4-new-messaging-verbs
branch
from
cc78760 to
dc8096f
Compare
michaelsembwever
added a commit
that referenced
this pull request
Jul 11, 2019
michaelsembwever
force-pushed
the
mck/fix-cassandra-4-new-messaging-verbs
branch
from
dc8096f to
f798244
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the messaging service rewrite in Cassandra 4.0 there has been an overhaul (and addition of many) of the VERBs: https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/net/Verb.java
This PR allows the dropped messages integration test step to use either VERB
READorREAD_REQto be compatible with all versions of Cassandra.