feat: skip untargeted node

thematters · May 4, 2023 · 9915362 · 9915362
1 parent 99415f7
commit 9915362
Show file tree

Hide file tree

Showing 5 changed files with 41 additions and 35 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@matters/matters-editor",
-  "version": "0.2.0-alpha.34",
+  "version": "0.2.0-alpha.35",
   "description": "Editor for matters.news",
   "author": "https://github.com/thematters",
   "homepage": "https://github.com/thematters/matters-editor",

diff --git a/src/editors/extensions/figureAudio.ts b/src/editors/extensions/figureAudio.ts
@@ -151,11 +151,13 @@ export const FigureAudio = Node.create({
             // @ts-ignore
             const editor = view.dom.editor as Editor
 
+            if (!isFigure) {
+              return
+            }
+
             // backSpace to remove if the figcaption is empty
-            if (event.key === 'BackSpace') {
-              if (isEmptyFigcaption && isFigure) {
-                editor.commands.deleteNode(pluginName)
-              }
+            if (event.key === 'BackSpace' && isEmptyFigcaption) {
+              editor.commands.deleteNode(pluginName)
             }
 
             // enter to insert a new paragraph

diff --git a/src/editors/extensions/figureEmbed.ts b/src/editors/extensions/figureEmbed.ts
@@ -335,11 +335,13 @@ export const FigureEmbed = Node.create({
             // @ts-ignore
             const editor = view.dom.editor as Editor
 
+            if (!isFigure) {
+              return
+            }
+
             // backSpace to remove if the figcaption is empty
-            if (event.key === 'BackSpace') {
-              if (isEmptyFigcaption && isFigure) {
-                editor.commands.deleteNode(pluginName)
-              }
+            if (event.key === 'BackSpace' && isEmptyFigcaption) {
+              editor.commands.deleteNode(pluginName)
             }
 
             // enter to insert a new paragraph

diff --git a/src/editors/extensions/figureImage.ts b/src/editors/extensions/figureImage.ts
@@ -105,11 +105,13 @@ export const FigureImage = Node.create({
             // @ts-ignore
             const editor = view.dom.editor as Editor
 
+            if (!isFigure) {
+              return
+            }
+
             // backSpace to remove if the figcaption is empty
-            if (event.key === 'BackSpace') {
-              if (isEmptyFigcaption && isFigure) {
-                editor.commands.deleteNode(pluginName)
-              }
+            if (event.key === 'BackSpace' && isEmptyFigcaption) {
+              editor.commands.deleteNode(pluginName)
             }
 
             // enter to insert a new paragraph