Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collection Editor Updates #248

Merged
merged 3 commits into from
Apr 30, 2019
Merged

Conversation

robertu7
Copy link
Contributor

@robertu7 robertu7 commented Apr 30, 2019

  • Fire setCollection mutation only when click save button in article sidebar

@codecov
Copy link

codecov bot commented Apr 30, 2019

Codecov Report

Merging #248 into develop will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #248      +/-   ##
===========================================
+ Coverage    47.53%   47.55%   +0.01%     
===========================================
  Files          221      221              
  Lines         3717     3716       -1     
  Branches       678      678              
===========================================
  Hits          1767     1767              
+ Misses        1932     1931       -1     
  Partials        18       18
Impacted Files Coverage Δ
...ponents/NoticeDigest/ArticleNewCollectedNotice.tsx 68.75% <ø> (+4.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49c9754...b1fb4b0. Read the comment docs.

@robertu7 robertu7 changed the title WIP: call setCollection mutation only when click save button in article sidebar Collection Editor Updates Apr 30, 2019
@robertu7 robertu7 added the ready label Apr 30, 2019
@robertu7 robertu7 merged commit 35adc91 into develop Apr 30, 2019
@delete-merged-branch delete-merged-branch bot deleted the enhancement/save-to-update-collection branch April 30, 2019 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants