-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/twmerge as composable #250
Conversation
+ support for user classes in FwbButton
Great suggestion, but if I'll add my custom class to button my classes will duplicated, to fix that you need to disable <template>
<component
v-bind="$attrs"
:is="buttonComponent"
:class="wrapperClasses"
:[linkAttr]="href"
:disabled="buttonComponent === 'button' && disabled"
>
...
</component>
</template> <script lang="ts" setup>
/// ...
defineOptions({
inheritAttrs: false,
})
/// ... |
Thanks, I'll take a look at this and prepare a fix. |
✅ Deploy Preview for sensational-seahorse-8635f8 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Hey @cogor 👋 I've tested different options here... and adding I've updated this PR with necessary changes... and I'm not getting duplicated classes and I'm able to add basic styles using regular class attribute. Let me know what do you think about this approach. |
Looks great |
This is a way to move
twMerge
as global composable instead of importing it each component.Also this is a way to solve issue with custom user classes... proof of concept working for button, and main container of navbar.