Upgrade to react-router v4 #248
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upgraded several node modules Moved eslint config to own file Created compose-with-tracker.js for compatibility with react-komposer v2
Polished ract-router v4 integration Using ProprTypes from prop-types modules since deprecation from React Added some global overrides to eslint config file
Removed unneeded Logout component
|
Hi, I'm planning on using base for my next project. Is there any approximate date when this will be updated to react-router v4? |
Also added the profile "registered" for all users, so every user has a default role.
|
Just use this PR until the main dev decides to merge. It has all things base 4.15.0 plus PR#244 and React Router v4 |
Also added the role "registered" for all new users, so every user has a default role.
| @@ -7,7 +7,7 @@ import { Meteor } from 'meteor/meteor'; | |||
|
|
|||
| const userName = () => { | |||
| const user = Meteor.user(); | |||
| const name = user && user.profile ? user.profile.name : ''; | |||
| const name = user ? user.name : ''; | |||
There was a problem hiding this comment.
just small fix
const name = user ? user.profile.name : '';
|
looking forward to official merge as well. thanks for the contribution! |
|
Any update on this? |
|
Stay tuned. There's an announcement on the future of Base coming week after
next.
…On Mon, May 29, 2017 at 7:39 AM, Taylor Pechacek ***@***.***> wrote:
Any update on this?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#248 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AHzdfjrBW0ITH4PH_p5nIwUa5x4uFHU5ks5r-rxxgaJpZM4NBFbo>
.
--
Ryan Glover
Founder/Author
The Meteor Chef
http://themeteorchef.com
http://twitter.com/themeteorchef
|
|
@themeteorchef great! Hope my PR helps a little bit |
|
Any update on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only thing missing is react-router-bootstrap I must whait to 0.24.0 be published on NPMDone...