Overlap integrals for a pair of basis sets #238
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@BradenDKelly It's becoming a daily routine. :) I did already try some other performance improvements, but further (significant) speedups without drastic code changes seem difficult to accomplish. For example, just vectorizing code inside the current bottleneck (
compute_overlap_gaussian_1d
) is not helpful because the arrays already too small at that level. Anyway, before doing anything more substantial, I'd figured it would be useful to add a feature to the overlap code, i.e. to compute overlaps between two basis sets, which are needed in #146 and #175. When trying to make things more efficient, we should not make it impossible to support this feature.